Attempt to use phpunit 10 compatible event system #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of what I have encountered can be seen here magento/magento2#39907
But in short, annotations are not working in 2.4.8 because of the changes to the phpunit event subscription system.
After speaking with @michielgerritsen he suggests its because we're using an old phpunit.xml, and basing off a fresh M2 installation could be the way to go.
I've had a look at the code and it seems like we're pulling in the phpunit 9 series XML, and trying to run it against the phpunit 10 series code, which has different event system handling.
I do not know how to test this fully, without getting the docker images built etc ?